Inspect PR changes to determine if subproject builds are needed. #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alliepiper
commented
Mar 28, 2024
•
alliepiper
commented
alliepiper
force-pushed
the
pr-restrict-projects
branch
from
c2b3704
to
aed0bd5
Compare
|
The copy-pr-bot doesn't expose base SHA information. I've filled an issue with them to see if they can somehow expose that info to us. |
1 task
1 task
jrhemstad
reviewed
Apr 3, 2024
alliepiper
force-pushed
the
pr-restrict-projects
branch
8 times, most recently
from
fff1723
to
a7f6ff4
Compare
alliepiper
force-pushed
the
pr-restrict-projects
branch
from
a7f6ff4
to
f8a5f1b
Compare
alliepiper
changed the title
miscco
reviewed
Apr 8, 2024
Comment on lines
+57
to
+61
| if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then | ||
| return 1 | ||
| else | ||
| return 0 | ||
| fi |
There was a problem hiding this comment.
I dont know who, but I guess there is a way to transform this into a
Suggested change
| if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then | |
| return 1 | |
| else | |
| return 0 | |
| fi | |
| return dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; | SOMETHING |
miscco
approved these changes
Apr 8, 2024
jrhemstad
reviewed
Apr 8, 2024
jrhemstad
reviewed
Apr 8, 2024
jrhemstad
reviewed
Apr 8, 2024
jrhemstad
approved these changes
Apr 8, 2024
miscco
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.